Repository navigation
feat(interaction): add real mouse-wheel primitive - #128
Merged
Merged
Conversation
NianJiuZst
marked this pull request as ready for review
August 21, 2026 14:47
Validate signed deltas and optional targets before browser work. Guard wheel steps against cancellation and deadlines, cancel at the daemon deadline, and keep session serialization through bounded cleanup. Reuse visible bounds to choose points inside clipped targets without changing other input tools. Expose wheel through browser_interact and document native input, zoom, completion and interruption semantics. Add CLI, protocol, dispatcher, queue, plugin and isolated Chromium regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bsk wheel --delta-y <pixels> [ref-or-selector]backed by the newtool.wheelRPCInput.dispatchMouseEventwithtype: "mouseWheel"at the viewport centre or an optional ref/selector action pointValidation
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo test --workspace --locked(237 CLI/daemon unit tests plus all integration and protocol tests)pnpm lintnode --test scripts/*.test.mjs--delta-y 600movedscrollYfrom0to600; the page observedisTrusted=truewheel '#panel' --delta-y 300moved the nested panel'sscrollTopfrom0to300whilewindowScrollYstayed0; the page again observedisTrusted=true